Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [do-not-merge] 🌱 Generics testing #10464

Closed
wants to merge 2 commits into from
Closed

[WIP] [do-not-merge] 🌱 Generics testing #10464

wants to merge 2 commits into from

Conversation

Danil-Grigorev
Copy link
Member

What this PR does / why we need it:
This PR is currently WIP and is only intended to test new controller-runtime generic approach in a larger project, and as a way to get early feedback on the new proposed builder methods meant to be used with generic types.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 18, 2024
@Danil-Grigorev
Refactor all controllers to generics
5117265 
- Point to fork CR, subject to change

Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev force-pushed the generics-testing branch 2 times, most recently from e9e663d to caeb5f1 Compare April 18, 2024 16:02
@Danil-Grigorev Danil-Grigorev changed the title [WIP] [do-not-review] Generics testing [WIP] [do-not-merge] Generics testing Apr 18, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the generics-testing branch 2 times, most recently from 86ced6f to 111e010 Compare April 19, 2024 08:32
@Danil-Grigorev
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-29-1-30-main

@Danil-Grigorev Danil-Grigorev changed the title [WIP] [do-not-merge] Generics testing [WIP] [do-not-merge] 🌱 Generics testing Apr 19, 2024
@Danil-Grigorev
Refactor on Alvaro's PR
414d92d 
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
@sbueringer sbueringer mentioned this pull request Apr 19, 2024
Merged
@k8s-ci-robot
Copy link
Contributor

@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 414d92d link false /test pull-cluster-api-apidiff-main
pull-cluster-api-verify-main 414d92d link true /test pull-cluster-api-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer sbueringer mentioned this pull request Apr 24, 2024
Merged
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2024
@sbueringer sbueringer mentioned this pull request Apr 26, 2024
Closed
@sbueringer
Copy link
Member

I think we don't need this anymore. Feel free to reopen otherwise

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

I think we don't need this anymore. Feel free to reopen otherwise

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gaston g-gaston Awaiting requested review from g-gaston

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danil-Grigorev @k8s-ci-robot @sbueringer